Rod Pemberton
2020-04-03 07:43:53 UTC
Hey Rugxulo,
I noticed Japheth put out a new HIMEMX as mentioned on Robert
Riebisch's "DOS Ain't Dead" forum. Since I'm not subscribed there,
could you ask Japheth why he removed the attributions at the top of the
assembly file in version 3.34 for code fixes by Ninho, Mateusz Viste,
and Rod Pemberton (me) for his new v3.35? Yet, he left in the older
attributions prior to his 2007 attribution. It would seem from the
comments in v3.35 that he entirely wrote the E820h routine - as there
was no mention of me ...- but the v3.35 E820h code appears to mostly be
the version I significantly rewrote for v3.34, but it's just relocated
into it's old location. Of course, I'd need to compare v3.33, v3.34,
v3.35 in depth to be sure what I coded back then, but in the
attribution, it says "japheth 2020: - v3.34: added multiple int 15h,
ax=e820h memory block support" as if the E820h routine was entirely new.
Is he taking total claim to the E820h code in v3.35? ... I'm not really
concerned about this, but removal of those attributions would make more
sense if it was a 100% rewrite or complete removal of the prior E820h
code.
Also, I didn't check to see if Ninho's or Mateusz Viste's changes were
still present in v3.35, or if other changes I made were still there
(see link below). I suspect that maybe he didn't see the newer
attributions, since they were probably only in v3.34, and I suspect he
started from his code base, e.g., v3.33. That could imply that Ninho's
and Mateusz Viste's fixes, as well as my other fixes were lost going
from v3.34 to v3.35. These may be valuable to someone. Could he (or
did he) review these? Or, did he start with v3.34 instead of v3.33?
Let Japheth know that the first paragraph here summarizes my changes to
HIMEMX v3.34 better than the attributions:
https://groups.google.com/d/msg/comp.os.msdos.programmer/jKuJKgUXRNU/UinoCvvJ1FoJ
Also, IIRC, there was an off by one bug for the command line size if
the size was 4GB in v3.34. I don't recall where that fix was posted.
Feel free to post this in full or what you think needs to be passed
along to Japheth on "DOS Ain't Dead", but do mention it's via
comp.os.msdos.programmer on Usenet. In fact, you could just post a
link to this via Google Groups.
Rod Pemberton
I noticed Japheth put out a new HIMEMX as mentioned on Robert
Riebisch's "DOS Ain't Dead" forum. Since I'm not subscribed there,
could you ask Japheth why he removed the attributions at the top of the
assembly file in version 3.34 for code fixes by Ninho, Mateusz Viste,
and Rod Pemberton (me) for his new v3.35? Yet, he left in the older
attributions prior to his 2007 attribution. It would seem from the
comments in v3.35 that he entirely wrote the E820h routine - as there
was no mention of me ...- but the v3.35 E820h code appears to mostly be
the version I significantly rewrote for v3.34, but it's just relocated
into it's old location. Of course, I'd need to compare v3.33, v3.34,
v3.35 in depth to be sure what I coded back then, but in the
attribution, it says "japheth 2020: - v3.34: added multiple int 15h,
ax=e820h memory block support" as if the E820h routine was entirely new.
Is he taking total claim to the E820h code in v3.35? ... I'm not really
concerned about this, but removal of those attributions would make more
sense if it was a 100% rewrite or complete removal of the prior E820h
code.
Also, I didn't check to see if Ninho's or Mateusz Viste's changes were
still present in v3.35, or if other changes I made were still there
(see link below). I suspect that maybe he didn't see the newer
attributions, since they were probably only in v3.34, and I suspect he
started from his code base, e.g., v3.33. That could imply that Ninho's
and Mateusz Viste's fixes, as well as my other fixes were lost going
from v3.34 to v3.35. These may be valuable to someone. Could he (or
did he) review these? Or, did he start with v3.34 instead of v3.33?
Let Japheth know that the first paragraph here summarizes my changes to
HIMEMX v3.34 better than the attributions:
https://groups.google.com/d/msg/comp.os.msdos.programmer/jKuJKgUXRNU/UinoCvvJ1FoJ
Also, IIRC, there was an off by one bug for the command line size if
the size was 4GB in v3.34. I don't recall where that fix was posted.
Feel free to post this in full or what you think needs to be passed
along to Japheth on "DOS Ain't Dead", but do mention it's via
comp.os.msdos.programmer on Usenet. In fact, you could just post a
link to this via Google Groups.
Rod Pemberton
--
"You wanted in and now you're here, driven by hate, consumed by fear."
"You wanted in and now you're here, driven by hate, consumed by fear."